Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for NdOverlay and Overlay in downsample1d #5856

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 15, 2023

Before the following code will always return the non-downsampled ndoverlay/overlay.

        if len(element) <= self.p.width:
            return element

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Merging #5856 (76a17bb) into main (ee01948) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5856      +/-   ##
==========================================
+ Coverage   88.24%   88.30%   +0.05%     
==========================================
  Files         309      310       +1     
  Lines       63921    63944      +23     
==========================================
+ Hits        56408    56466      +58     
+ Misses       7513     7478      -35     
Flag Coverage Δ
ui-tests 23.38% <30.43%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/operation/downsample.py 84.90% <100.00%> (+84.90%) ⬆️
holoviews/tests/operation/test_downsample.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro force-pushed the downsample1d_overlay branch from bb6c994 to 808f5d7 Compare August 15, 2023 15:21
@hoxbro hoxbro added this to the 1.17.1 milestone Aug 16, 2023
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hoxbro hoxbro merged commit 5064811 into main Aug 16, 2023
@hoxbro hoxbro deleted the downsample1d_overlay branch August 16, 2023 10:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants