Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle parameter references from Param 2.0 #5906

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Handle parameter references from Param 2.0 #5906

merged 6 commits into from
Sep 25, 2023

Conversation

philippjfr
Copy link
Member

Avoids various warnings when working with Param 2.0

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2023

Codecov Report

Merging #5906 (bbc47d4) into main (79008ed) will decrease coverage by 0.02%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##             main    #5906      +/-   ##
==========================================
- Coverage   88.41%   88.39%   -0.02%     
==========================================
  Files         312      312              
  Lines       64953    64967      +14     
==========================================
+ Hits        57427    57429       +2     
- Misses       7526     7538      +12     
Flag Coverage Δ
ui-tests 23.32% <4.76%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
holoviews/util/__init__.py 73.97% <ø> (ø)
holoviews/streams.py 86.91% <63.63%> (-0.35%) ⬇️
holoviews/core/util.py 85.55% <75.00%> (-0.53%) ⬇️
holoviews/core/spaces.py 84.62% <100.00%> (-0.05%) ⬇️
holoviews/tests/util/test_transform.py 95.75% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr changed the title Explicitly disable allow_refs on Callable Handle parameter references from Param 2.0 Sep 25, 2023
holoviews/streams.py Outdated Show resolved Hide resolved
@philippjfr philippjfr marked this pull request as ready for review September 25, 2023 12:32
@hoxbro hoxbro enabled auto-merge (squash) September 25, 2023 12:33
@hoxbro hoxbro merged commit 2aca2f7 into main Sep 25, 2023
11 checks passed
@hoxbro hoxbro deleted the fix_allow_refs branch September 25, 2023 13:10
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants