-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Python 3.12 for core test #5909
Merged
Changes from 17 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ea7070b
Try 3.12 for core test
hoxbro d807fd7
Update install branch
hoxbro eef8931
Remove channel-priority:
hoxbro c0b656b
Remove conda channel
hoxbro 1ce2351
Merge branch 'main' into try_312
hoxbro 5fc34ea
Use pip to check for Python 3.12
hoxbro b491e65
tests_ci for consistency
hoxbro f2d2125
Update install
hoxbro b85bdb5
Add checkout
hoxbro 2f6392c
Debug
hoxbro 0b11813
Set mpl backend in conftest
hoxbro f1f8f96
Check for different heights
hoxbro c99f072
Fix bitwise inversion '~' on bool deprecation warning
hoxbro e245aac
Ignore warnings outside our control
hoxbro 827b6f1
Add Python 3.12 in setup.py and tox.ini
hoxbro 8ffe34e
Handle pd.isna(None) and pd.isna((None, None))
hoxbro 3355020
Ignore all bokeh utc warnings
hoxbro 883f1cb
Remove utcnow too
hoxbro 6098813
Add back deleted line
hoxbro db5e6cd
Merge branch 'main' into try_312
hoxbro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,6 @@ | |
'bokeh', | ||
'pillow', | ||
'plotly >=4.0', | ||
'dash >=1.16', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a core-test package. Moved it down to tests. |
||
'ipython >=5.4.0', | ||
] | ||
|
||
|
@@ -57,9 +56,10 @@ | |
'selenium', | ||
'spatialpandas', | ||
'datashader >=0.11.1', | ||
'dash >=1.16', | ||
] | ||
|
||
extras_require['test_ci'] = [ | ||
extras_require['tests_ci'] = [ | ||
'codecov', | ||
"pytest-github-actions-annotate-failures", | ||
] | ||
|
@@ -184,6 +184,7 @@ def get_setup_version(reponame): | |
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
"Operating System :: OS Independent", | ||
"Intended Audience :: Science/Research", | ||
"Intended Audience :: Developers", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From this Python 3.12 warning:
Bitwise inversion '~' on bool is deprecated. This returns the bitwise inversion of the underlying int object and is usually not what you expect from negating a bool. Use the 'not' operator for boolean negation or ~int(x) if you really want the bitwise inversion of the underlying int.
And val sometimes could be None or a tuple of None.