Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sys.executable for check_output #5983

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Use sys.executable for check_output #5983

merged 1 commit into from
Nov 16, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 14, 2023

This seems more correct

@hoxbro
Copy link
Member Author

hoxbro commented Nov 14, 2023

@MeggyCal, will this still work for you?

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c72201) 88.58% compared to head (75f57c8) 88.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5983      +/-   ##
==========================================
- Coverage   88.58%   88.57%   -0.02%     
==========================================
  Files         315      315              
  Lines       65554    65554              
==========================================
- Hits        58074    58064      -10     
- Misses       7480     7490      +10     
Flag Coverage Δ
ui-tests 23.15% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MeggyCal
Copy link
Contributor

Yes, that would still work :) thank you.

@hoxbro hoxbro merged commit 44b0bff into main Nov 16, 2023
10 checks passed
@hoxbro hoxbro deleted the use_sys_exec branch November 16, 2023 10:49
@hoxbro hoxbro added the type: enhancement Minor feature or improvement to an existing feature label Nov 23, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants