Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip statement to all steps to work with required #6037

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 16, 2023

There is no way to exit early in Github Actions, and I want to have the required pass.

Also, I took the time to remove the default shell to the top of the workflow and formatted the script.

@hoxbro hoxbro changed the title Add skip code Add skip statement to all steps to work with required Dec 16, 2023
@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Dec 16, 2023
@hoxbro hoxbro enabled auto-merge (squash) December 16, 2023 10:56
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (efed87d) 88.65% compared to head (309bb0e) 88.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6037   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         315      315           
  Lines       65661    65661           
=======================================
  Hits        58209    58209           
  Misses       7452     7452           
Flag Coverage Δ
ui-tests 23.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit 804d56b into main Dec 16, 2023
12 checks passed
@hoxbro hoxbro deleted the add_skip_code branch December 16, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants