Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show figures toolbar on GridSpace #6127

Merged
merged 10 commits into from
Feb 23, 2024
Merged

Don't show figures toolbar on GridSpace #6127

merged 10 commits into from
Feb 23, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 22, 2024

Fixes #6126

Also took the time to simplify the UI test for holoviews

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Feb 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.69%. Comparing base (c3c211e) to head (3c96569).

Files Patch % Lines
holoviews/tests/conftest.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6127      +/-   ##
==========================================
- Coverage   88.70%   88.69%   -0.02%     
==========================================
  Files         314      316       +2     
  Lines       65993    66010      +17     
==========================================
+ Hits        58537    58545       +8     
- Misses       7456     7465       +9     
Flag Coverage Δ
ui-tests 23.79% <83.05%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) February 23, 2024 14:13
@hoxbro hoxbro merged commit a66eb55 into main Feb 23, 2024
12 checks passed
@hoxbro hoxbro deleted the scattermatrix branch February 23, 2024 14:40
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many toolbars on grid plots
3 participants