Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Bokeh BoxWhisker #6169

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Fixes to Bokeh BoxWhisker #6169

merged 4 commits into from
Apr 5, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 3, 2024

Fixes #6166

import holoviews as hv
import numpy as np

hv.extension("bokeh")

x = np.random.randn(1000)
hv.BoxWhisker(x, vdims="Value")

image

Fixes #5431

import holoviews as hv
import pandas as pd
hv.extension("bokeh")
df = pd.DataFrame(
    {
        "data": [1, 2, 4, 5, 2, 3, 3, 2, 20, 34],
        "data 2": [1, 2, 4, 5, 2, 3, 3, 2, 20, 34],
        "data[": [1, 2, 4, 5, 2, 3, 3, 2, 20, 34],
        "x": [1, 1, 1, 1, 1, 1, 1, 1, 1, 1],
    }
)

(
    hv.BoxWhisker(df, "x", "data", label="data")
    + hv.BoxWhisker(df, "x", "data 2", label="data 2")
    + hv.BoxWhisker(df, "x", "data[", label="data[")
)

image

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Apr 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.68%. Comparing base (342d81c) to head (b0fbfd2).
Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/plotting/bokeh/stats.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6169   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files         316      316           
  Lines       66072    66073    +1     
=======================================
+ Hits        58598    58599    +1     
  Misses       7474     7474           
Flag Coverage Δ
ui-tests 23.79% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro changed the title Add radius to BoxWhisker Fixes to Bokeh BoxWhisker Apr 3, 2024
@hoxbro hoxbro merged commit fef3219 into main Apr 5, 2024
11 checks passed
@hoxbro hoxbro deleted the boxwhisker_outliers branch April 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
3 participants