Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze models while updating plot(s) #6315

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Freeze models while updating plot(s) #6315

merged 3 commits into from
Jul 8, 2024

Conversation

philippjfr
Copy link
Member

Uses the ability to freeze the Bokeh Document model graph while a plot is being updated to avoid needlessly recomputing the graph over and over. Results in about a 10% speed improvement during plot updates.

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (28cbd14) to head (c4696c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6315   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files         323      323           
  Lines       68092    68098    +6     
=======================================
+ Hits        60271    60277    +6     
  Misses       7821     7821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member Author

ffmpeg issue fixed by pinning in this PR but will update the lock separately.

@philippjfr philippjfr merged commit 55856e1 into main Jul 8, 2024
10 of 12 checks passed
@philippjfr philippjfr deleted the freeze_models branch July 8, 2024 15:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant