Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally skip testing the Gridded data user guide #1383

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 29, 2024

Because of pydata/xarray#9182 which has been merged but not yet released.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (feffee5) to head (54b1572).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   88.87%   88.87%           
=======================================
  Files          51       51           
  Lines        7478     7479    +1     
=======================================
+ Hits         6646     6647    +1     
  Misses        832      832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt maximlt merged commit 8bb9391 into main Jul 30, 2024
9 checks passed
@maximlt maximlt deleted the cond_skip_gridded branch July 30, 2024 13:22
@maximlt
Copy link
Member Author

maximlt commented Jul 30, 2024

Xarray was released with the fix (https://github.com/pydata/xarray/releases/tag/v2024.07.0) but merging this anyway to avoid hitting this issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant