Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI tests to the Tabulator widget #3631

Closed
maximlt opened this issue Jun 17, 2022 · 1 comment
Closed

Add UI tests to the Tabulator widget #3631

maximlt opened this issue Jun 17, 2022 · 1 comment
Labels
component: tabulator Related to the Tabulator widget type: enhancement Minor feature or improvement to an existing feature

Comments

@maximlt
Copy link
Member

maximlt commented Jun 17, 2022

A framework to implement UI tests - PlayWright - has recently been added to the test suite. An obvious candidate for UI tests is the Tabulator widget that is not provided by Bokeh (Bokeh has its own UI tests), has many features, some of them being deeply interlinked. UI tests should prevent regressions that can currently happen pretty easily as they can't be caught with non-UI tests. It is likely that adding these tests will uncover some bugs and highlight those that are already known.
@maximlt maximlt added type: enhancement Minor feature or improvement to an existing feature component: tabulator Related to the Tabulator widget labels Jun 17, 2022
This was referenced Jun 17, 2022
Closed
Merged
@maximlt
Copy link
Member Author

maximlt commented Aug 8, 2022

Many tests were added in #3633. This is never enough, but enough to close this issue :)

@maximlt maximlt closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: tabulator Related to the Tabulator widget type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maximlt