Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Tabulator widget to use Tabulator JS 5.x #3632

Closed
2 tasks done
maximlt opened this issue Jun 17, 2022 · 1 comment
Closed
2 tasks done

Upgrade the Tabulator widget to use Tabulator JS 5.x #3632

maximlt opened this issue Jun 17, 2022 · 1 comment
Labels
component: tabulator Related to the Tabulator widget type: enhancement Minor feature or improvement to an existing feature

Comments

@maximlt
Copy link
Member

maximlt commented Jun 17, 2022

The Tabulator widget relies on the 4.9.3 version of the Tabulator JS library while its latest version is the 5.2.7. An upgrade to Tabulator 5.x (5.0.7 at the time) was already attempted last year (#2898) but had to be reverted (#3094) as major performance hits were observed. This issue was reported to the Tabulator's maintainer (olifolkerd/tabulator#3530) who indicated having fixed it in a subsequent release. Given the time frame since the last upgrade attempt, it appears reasonable to think that Tabulator 5 is now stable and should no longer have the performance hits that were observed.

  • Before upgrading, the Tabulator widget should be covered by an extensive number of UI tests. Tabulator 5 was a major update and the widget upgrade could cause many regressions that would be difficult to catch without a proper UI test suite: Add UI tests to the Tabulator widget #3631
  • We should check that the performance hits observed with the 5.0.7 version have effectively been fixed
@maximlt maximlt added type: enhancement Minor feature or improvement to an existing feature component: tabulator Related to the Tabulator widget labels Jun 17, 2022
@maximlt maximlt changed the title Upgrade Tabulator JS to its 5.2 version Upgrade the Tabulator widget to use Tabulator JS 5.x Jun 17, 2022
@maximlt
Copy link
Member Author

maximlt commented Feb 13, 2023

Closed in #3784

@maximlt maximlt closed this as completed Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabulator Related to the Tabulator widget type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant