Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not process events related to fake Template root #1216

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 1, 2020

Panel was built around the idea that everything has a single root model which contains all the other models. Templates came along and broke that assumption, because it allows you to insert multiple roots at different points of an Jinja template.

To deal with that we create a fake root model, which makes things like cross-root linking of axes and JS links across roots work. However the rest of the code was not aware this thing was a fake, so it was creating duplicate models for it and keeping them all updated. So bad news is, that’s a horrific bug, good news is everything that was using templates is about to get 2x faster.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Apr 1, 2020
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1216 into master will decrease coverage by 0.02%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   87.44%   87.41%   -0.03%     
==========================================
  Files         106      106              
  Lines       12607    12619      +12     
==========================================
+ Hits        11024    11031       +7     
- Misses       1583     1588       +5     
Impacted Files Coverage Δ
panel/widgets/base.py 80.95% <0.00%> (-1.98%) ⬇️
panel/pane/base.py 89.00% <50.00%> (-0.40%) ⬇️
panel/layout.py 84.61% <75.00%> (-0.16%) ⬇️
panel/viewable.py 77.38% <87.50%> (ø)
panel/io/state.py 90.19% <100.00%> (+0.19%) ⬆️
panel/template.py 66.93% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dae714...ce37461. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant