Do not process events related to fake Template root #1216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panel was built around the idea that everything has a single root model which contains all the other models. Templates came along and broke that assumption, because it allows you to insert multiple roots at different points of an Jinja template.
To deal with that we create a fake root model, which makes things like cross-root linking of axes and JS links across roots work. However the rest of the code was not aware this thing was a fake, so it was creating duplicate models for it and keeping them all updated. So bad news is, that’s a horrific bug, good news is everything that was using templates is about to get 2x faster.