-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Card and Accordion layout [doc-build] #1262
Conversation
This is really really cool! |
Looks nice. Does it support
For example I might like to put an icon in there, a link or set the "size"/ "type" of header? |
Here are the docs I'm about to add, you'll see an example with a logo: https://anaconda.org/philippjfr/card/notebook |
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
+ Coverage 87.30% 87.53% +0.22%
==========================================
Files 106 117 +11
Lines 12662 12952 +290
==========================================
+ Hits 11055 11337 +282
- Misses 1607 1615 +8
Continue to review full report at Codecov.
|
09750e8
to
76b5d55
Compare
Hi @philippjfr It's great. Here is a little feedback.
Difficult to hit toggleDivider between objectsBlue border when clicking +/-Scroll includes title/ header |
@MarcSkovMadsen Thanks for the feedback, a lot of what you're seeing is simply because anaconda.org defines various CSS which does not seem to work too well with the Card CSS. I'll try to make sure they don't interfere like that but there's only so much we can do.
It is actually considerably larger than it appears on anaconda.org, it defines various CSS tags that interfere with the actual look and feel. I'll still try to make it larger though.
Personally I prefer +/- and again they appear much larger and bolder without anaconda.org's theme interferring. I'll try to make sure that external CSS doesn't interfere like that.
Happy to add an example, much less happy adding dividers by default.
Again, this is anaconda.org CSS, not part of the default look.
Unlikely to be easy, but I'll give that a shot. |
I'm super excited to see this!! 🎉 |
Merging for now. We can add additional tweaks later. |
Supersedes #1182
Adds a Card model with configurable HTML tags and css classes and collapse button
Here's what it will look like in the coming Material design template: