Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing the title of each app served with pn.serve #1354

Merged
merged 4 commits into from
May 19, 2020

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 18, 2020

Fixes #1292

@philippjfr When you have the time please let me know if you're fine with the tests :)

panel/io/server.py Outdated Show resolved Hide resolved
panel/io/server.py Outdated Show resolved Hide resolved
panel/io/server.py Outdated Show resolved Hide resolved
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code, tests and docs all look good, just a few misspelling of dictionary to fix. Thanks so much!

@maximlt
Copy link
Member Author

maximlt commented May 19, 2020

Oops got confused with the French word... Thanks for the edits, I guess that you can merge it now, or do I still have something to do?

@philippjfr philippjfr merged commit cd4e889 into holoviz:master May 19, 2020
philippjfr added a commit that referenced this pull request May 24, 2020
* Customize title for multi apps

* Test the title kwarg of pn.serve

* Update the deploy docs with the kwarg title of pn.serve

* Apply suggestions from code review

Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Title functionality of panel.serve to be specific for each app served
2 participants