Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non-existent models in Template do not cause errors #1374

Merged
merged 1 commit into from
May 29, 2020

Conversation

philippjfr
Copy link
Member

Certain components do not render their models immediately instead preferring to do so lazily. The Template however expects all models to be available on initial render. This PR ensures that components that have not yet been instantiated are simply skipped avoiding any resultant errors.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label May 29, 2020
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1374 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   87.69%   87.68%   -0.01%     
==========================================
  Files         130      130              
  Lines       13922    13927       +5     
==========================================
+ Hits        12209    12212       +3     
- Misses       1713     1715       +2     
Impacted Files Coverage Δ
panel/template/base.py 56.25% <66.66%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4e889...0a2e3f2. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator

Does that mean you can have a template with {{ panel_10 }} but not add_panel with name panel_10? That would be nice.

@philippjfr
Copy link
Member Author

No, totally unrelated to that but please open an issue about that.

@philippjfr philippjfr merged commit 6fd03b9 into master May 29, 2020
@philippjfr philippjfr deleted the tab_template_fixes branch May 29, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants