Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] Restore offscreen parameters and test vtkmodules #1402

Closed
wants to merge 1 commit into from

Conversation

xavArtley
Copy link
Collaborator

fix #1401

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #1402 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1402   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         131      131           
  Lines       14072    14074    +2     
=======================================
+ Hits        12313    12315    +2     
  Misses       1759     1759           
Impacted Files Coverage Δ
panel/pane/vtk/vtk.py 87.69% <100.00%> (ø)
panel/pane/vtk/vtkjs_serializer.py 82.16% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b08bba...25c08fb. Read the comment docs.

@philippjfr
Copy link
Member

Sorry, thought I'd merge your major VTK refactor first and obviously now there are conflicts.

@xavArtley
Copy link
Collaborator Author

Not a problem
It's some small changes that I will report

@xavArtley
Copy link
Collaborator Author

superseded by #1406

@xavArtley xavArtley deleted the xav/vtk_fix_1401 branch June 12, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VTK - vtkmodules - VTK pane does not support objects of type 'vtkWin32OpenGLRenderWindow'
2 participants