Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK Fix] Ensure camera change is emit after mouse interaction #1409

Merged
merged 1 commit into from
Jun 13, 2020
Merged

[VTK Fix] Ensure camera change is emit after mouse interaction #1409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion panel/models/vtk/vtklayout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,10 @@ export abstract class AbstractVTKView extends PanelHTMLBoxView {
// update camera model state only at the end of the interaction
// with the scene (avoid bouncing events and large amount of events)

const update_model_camera = () => this._get_camera_state()
const update_model_camera = () => {
this._get_camera_state()
this.model.properties.camera.change.emit()
}
const interactor = this._vtk_renwin.getInteractor()
const event_list = ["LeftButtonRelease", "RightButtonRelease", "EndAnimation"]
event_list.forEach((event) => interactor['on' + event](update_model_camera))
Expand Down