-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Template Examples #1459
Add Template Examples #1459
Conversation
Might be good to put a note in there to say that rendering the templates in the notebook may not render correctly and that you really want to deploy to a server. On the website these will be iframed server apps so they'll look okay. |
Consider whether you can make the templates work in the notebook. One of the unique selling points of Panel is how well it works in both notebook and on server. It should be possible to do. For example the Material Template example I initially contributed works in both environments. |
That is a point well taken. I don't think it necessarily needs to happen in the first cut of this PR though. |
I am currently looking through the new template implementation which I'm really looking forward to. I just wanted to share my comments/ questions.
|
That would be great.
I have thought about it but don't yet have a good solution to dynamically switch out the CSS.
I am very happy to accept further
I need to have another look at the way the header works, while I think what you're asking for will work with enough fiddling I've found position items in the header the most difficult part of using these templates.
Yes, was planning on supporting this where possible, just wasn't the highest priority.
I'll think about this.
Yes, I have not had a lot of time to look at the CSS styling for different templates/themes and was hoping this would be something we would slowly fill in over time. |
Codecov Report
@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
- Coverage 85.68% 85.68% -0.01%
==========================================
Files 147 147
Lines 16462 16440 -22
==========================================
- Hits 14106 14086 -20
+ Misses 2356 2354 -2
Continue to review full report at Codecov.
|
7706d05
to
2b8cfb9
Compare
This PR is adding examples for the new and old templates to the Panel Reference Gallery. It can't be merged until the Vanilla and Golden Layout Templates are merged in, but I wanted to go ahead and get feedback on the documentation included.
I also noticed that including
.servable()
looks a bit rough, and that the input widgets aren't working when the template is rendered within the notebook. This is a screenshot of an example using the Bootstrap template: