-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for interactive mode on Matplotlib #1469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1469 +/- ##
==========================================
- Coverage 86.44% 85.74% -0.71%
==========================================
Files 138 138
Lines 15361 15618 +257
==========================================
+ Hits 13279 13391 +112
- Misses 2082 2227 +145
Continue to review full report at Codecov.
|
I thought the ipywidgets where costly to load and as such native bokeh/ panel implementations where preferred? |
Sure, but there are plenty of plots available from Matplotlib not available anywhere else, plus some people just prefer Matplotlib. Panel has no opinion about what plotting library you use, though of course each one comes with tradeoffs... |
Also this is entirely optional, I'm just giving users access to this capability. |
Its not that i dont like. I do. I’m just trying to understand when a native implementation is required and when ipywidgets version Can be used. There Probably are a lot of things that Can be done via ipywidgets. Ivuetify for example. Would it be ok to give users easy access to these in Panel via Param or would it be something you can do but really should not do? Instead bokeh models should be built? |
Sure. I'd say that there is a large class of things that can very easily be made available to Panel users in some usable form. Some of those could be made much more performant if someone wants to invest time and energy into them, but if even the easily obtained version is already usable in many cases, why not? I'd only invest in making a highly optimized special version if it's really needed; in the meantime it's great that more things just work! |
* Add support for interactive mode on Matplotlib * Minor fixes * Add ipympl * Fix for pn.ipywidget
So that we can keep track of to-do items, please open two separate issues, each listing the relevant software versions and describing that specific problem. Comments on closed or merged PRs are very likely to get overlooked! |
Adds support for interactive Matplotlib plots based on ipympl.