Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with requirejs and templates #1472

Merged
merged 7 commits into from
Jul 9, 2020
Merged

Fix issues with requirejs and templates #1472

merged 7 commits into from
Jul 9, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 9, 2020

Some unfortunate workarounds and other miscellaneous fixes. Would like to find a better solution to handling requirejs but for now we add some workarounds that ensure requirejs does not clash with the require/define utilities provided by Ace. Also fixes a few other issues.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1472 into master will decrease coverage by 0.01%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1472      +/-   ##
==========================================
- Coverage   86.20%   86.19%   -0.02%     
==========================================
  Files         139      139              
  Lines       15445    15459      +14     
==========================================
+ Hits        13315    13325      +10     
- Misses       2130     2134       +4     
Impacted Files Coverage Δ
panel/depends.py 63.63% <0.00%> (ø)
panel/command/serve.py 17.33% <20.00%> (+0.66%) ⬆️
panel/layout/accordion.py 84.72% <66.66%> (-0.79%) ⬇️
panel/io/resources.py 91.83% <100.00%> (-1.19%) ⬇️
panel/io/server.py 62.43% <100.00%> (+0.37%) ⬆️
panel/layout/card.py 95.74% <100.00%> (ø)
panel/layout/grid.py 75.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d817c...1917c2c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant