-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of (Int|Float)[Input|Spinner] (New Bokeh widgets) #1513
Conversation
I think we should be consistent about it so I'm happy to make sure we introduce distinct Int/Float widgets throughout. |
37358fe
to
11af5d9
Compare
ce19014
to
e02242a
Compare
e02242a
to
050e6da
Compare
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
- Coverage 85.68% 85.67% -0.01%
==========================================
Files 147 147
Lines 16411 16438 +27
==========================================
+ Hits 14061 14084 +23
- Misses 2350 2354 +4
Continue to review full report at Codecov.
|
Please do a rename while you are at it to |
For me spinner is the right name for the i put with arrows https://en.m.wikipedia.org/wiki/Spinner_(computing) . In this PR there is already Int and Float Input widget (if no step is given) and an Int and Float Spinner if step is defined. |
I think |
I think we've now agreed that we should do the renaming from |
@philippjfr, I'm a bit short on time, I'll be glad if you could do it. |
Int, Float separation or not separation?