Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of (Int|Float)[Input|Spinner] (New Bokeh widgets) #1513

Merged
merged 7 commits into from
Oct 6, 2020

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Aug 4, 2020

Int, Float separation or not separation?

  • Need to update documentation

@philippjfr
Copy link
Member

I think we should be consistent about it so I'm happy to make sure we introduce distinct Int/Float widgets throughout.

@xavArtley xavArtley force-pushed the xav/new_bk_numeric_input_spinner branch from 37358fe to 11af5d9 Compare August 28, 2020 13:55
@xavArtley xavArtley force-pushed the xav/new_bk_numeric_input_spinner branch 2 times, most recently from ce19014 to e02242a Compare September 6, 2020 15:25
@xavArtley xavArtley force-pushed the xav/new_bk_numeric_input_spinner branch from e02242a to 050e6da Compare September 6, 2020 15:47
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #1513 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1513      +/-   ##
==========================================
- Coverage   85.68%   85.67%   -0.01%     
==========================================
  Files         147      147              
  Lines       16411    16438      +27     
==========================================
+ Hits        14061    14084      +23     
- Misses       2350     2354       +4     
Impacted Files Coverage Δ
panel/param.py 91.59% <ø> (ø)
panel/widgets/__init__.py 100.00% <ø> (ø)
panel/widgets/input.py 95.01% <ø> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19abe5c...813f86d. Read the comment docs.

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Sep 8, 2020

Please do a rename while you are at it to IntInput and FloatInput as the Spinner name is just confusing. I always thinks is something indicating progress. That's what it is in all other frameworks I know of.

@xavArtley
Copy link
Collaborator Author

xavArtley commented Sep 8, 2020

For me spinner is the right name for the i put with arrows https://en.m.wikipedia.org/wiki/Spinner_(computing) . In this PR there is already Int and Float Input widget (if no step is given) and an Int and Float Spinner if step is defined.
if there is a consensus to change the name, I would.

@philippjfr
Copy link
Member

I think Spinner on it's own is indeed confusing but IntSpinner and FloatSpinner actually resolve the ambiguity for me.

@philippjfr
Copy link
Member

I think we've now agreed that we should do the renaming from Spinner -> NumberInput in #1566. So could you start by renaming FloatSpinner and IntSpinner to FloatInput and IntInput in this PR? (If you're short on time I can do it).

@xavArtley
Copy link
Collaborator Author

@philippjfr, I'm a bit short on time, I'll be glad if you could do it.
Thanks

@philippjfr philippjfr merged commit 23184e3 into master Oct 6, 2020
@philippjfr philippjfr deleted the xav/new_bk_numeric_input_spinner branch October 6, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants