Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled disabled dates #1524

Merged
merged 9 commits into from
Aug 11, 2020
Merged

Enabled disabled dates #1524

merged 9 commits into from
Aug 11, 2020

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Aug 9, 2020

@codecov
Copy link

codecov bot commented Aug 9, 2020

Codecov Report

Merging #1524 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1524   +/-   ##
=======================================
  Coverage   85.70%   85.70%           
=======================================
  Files         144      144           
  Lines       15968    15970    +2     
=======================================
+ Hits        13685    13687    +2     
  Misses       2283     2283           
Impacted Files Coverage Δ
panel/widgets/input.py 96.15% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f860842...73f1e31. Read the comment docs.

@philippjfr
Copy link
Member

Great, thanks so much! Could we also document these parameters in examples/reference/widgets/DatePicker.ipynb so they show up here: https://panel.holoviz.org/reference/widgets/DatePicker.html

@philippjfr philippjfr merged commit f2e1bf8 into holoviz:master Aug 11, 2020
philippjfr pushed a commit that referenced this pull request Sep 17, 2020
* Allow embedding local file

* Remove is_url check

* Reverse logic

* Add disabled_dates and enabled_dates to DatePicker

* Add docs

Co-authored-by: ahuang11 <ahuang11@illinois.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants