Switch away from inline resources in notebook #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
the
type: enhancement
|
Do have to figure out how we can ensure a smooth dev experience and what happens for dev builds when no CDN release of Panel.js is available. |
Codecov Report
@@ Coverage Diff @@
## master #1538 +/- ##
==========================================
- Coverage 85.69% 85.65% -0.04%
==========================================
Files 146 146
Lines 16069 16076 +7
==========================================
Hits 13770 13770
- Misses 2299 2306 +7
Continue to review full report at Codecov.
|
philippjfr
force-pushed
the
no_inline_resources
branch
from
6105181 to
c609a9f
Compare
philippjfr
force-pushed
the
no_inline_resources
branch
from
34363f5 to
03b840d
Compare
philippjfr
force-pushed
the
no_inline_resources
branch
from
03b840d to
3b927c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panel depends on various external resources to work properly so until that is resolved there is zero point using inline resources and significant cost as it slows down page load and is just generally not recommended.