-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to serialize all vtkDataset arrays #1596
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
- Coverage 85.68% 85.34% -0.35%
==========================================
Files 147 147
Lines 16460 16705 +245
==========================================
+ Hits 14104 14257 +153
- Misses 2356 2448 +92
Continue to review full report at Codecov.
|
# if backPropertyInstance: | ||
# instance['dependencies'].append(backPropertyInstance) | ||
# instance['calls'].append(['setBackfaceProperty', [wrapId(backfacePropId)]]) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can keep this if vtkjs is going to support backface color we won't have to rethink about it
Apart from a few comments this looks fine to me. However I do worry about continuing to expand the custom serializer so just checking where are we on using the native vtk serializer? |
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
|
Okay, merging for now. |
A vtk dataset can contain several data arrays but only one is used to color the mesh, the "active scalars".
Until now only this array was serialized, it allow to minimize the size of the serialized scene.
However by allowing the serialization of all data arrays and using some custom javascript functions we could make some temporal 3d visualization easier.
This PR add a parameter
serialize_all_data_arrays
to allow thisHere is a comparison between both options: