Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files in FileInput #1911

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Multiple files in FileInput #1911

merged 3 commits into from
Jan 18, 2021

Conversation

miliante
Copy link
Contributor

Update input.py to add 'multiple' parameter to FileInput
paramenter filename can be a string or a list
parameter mime_type can be a string or a list
_process_property_change accounts for either a string or a list as input for 'msg'

Update input.py to add 'multiple' parameter to FileInput
paramenter filename can be a string or a list
parameter mime_type can be a string or a list
_process_property_change accounts for either a string or a list as input for 'msg'
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #1911 (a926087) into master (7dacd8a) will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
+ Coverage   85.10%   85.14%   +0.03%     
==========================================
  Files         152      152              
  Lines       18913    18931      +18     
==========================================
+ Hits        16096    16118      +22     
+ Misses       2817     2813       -4     
Impacted Files Coverage Δ
panel/widgets/input.py 95.85% <83.33%> (-0.29%) ⬇️
panel/tests/widgets/test_button.py 100.00% <0.00%> (ø)
panel/param.py 90.34% <0.00%> (+0.03%) ⬆️
panel/widgets/button.py 87.14% <0.00%> (+7.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dacd8a...a926087. Read the comment docs.

panel/widgets/input.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Thanks so much! If you could, would you add some documentation for the multiple parameter to examples/reference/widgets/FileInput.ipynb?

@miliante
Copy link
Contributor Author

I was thinking, perhaps default should be false to avoid breaking compatibility with what everyone has already.

@philippjfr
Copy link
Member

I was thinking, perhaps default should be false to avoid breaking compatibility with what everyone has already.

Definitely.

Changed the default to False to avoid breaking compatibility
@philippjfr philippjfr merged commit d0afc43 into holoviz:master Jan 18, 2021
@philippjfr
Copy link
Member

Thanks for your contributions @miliante. I'll make the documentation updates in a new PR.

philippjfr pushed a commit that referenced this pull request Jan 18, 2021
* Multiple files in FileInput

Update input.py to add 'multiple' parameter to FileInput
paramenter filename can be a string or a list
parameter mime_type can be a string or a list
_process_property_change accounts for either a string or a list as input for 'msg'

* Update input.py

* Correct the default to False

Changed the default to False to avoid breaking compatibility
@miliante
Copy link
Contributor Author

Thank you @philippjfr. Sorry for late replies. I'll keep the documentation in mind for next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants