-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple files in FileInput #1911
Conversation
Update input.py to add 'multiple' parameter to FileInput paramenter filename can be a string or a list parameter mime_type can be a string or a list _process_property_change accounts for either a string or a list as input for 'msg'
Codecov Report
@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
+ Coverage 85.10% 85.14% +0.03%
==========================================
Files 152 152
Lines 18913 18931 +18
==========================================
+ Hits 16096 16118 +22
+ Misses 2817 2813 -4
Continue to review full report at Codecov.
|
Thanks so much! If you could, would you add some documentation for the multiple parameter to |
I was thinking, perhaps default should be false to avoid breaking compatibility with what everyone has already. |
Definitely. |
Changed the default to False to avoid breaking compatibility
Thanks for your contributions @miliante. I'll make the documentation updates in a new PR. |
* Multiple files in FileInput Update input.py to add 'multiple' parameter to FileInput paramenter filename can be a string or a list parameter mime_type can be a string or a list _process_property_change accounts for either a string or a list as input for 'msg' * Update input.py * Correct the default to False Changed the default to False to avoid breaking compatibility
Thank you @philippjfr. Sorry for late replies. I'll keep the documentation in mind for next time. |
Update input.py to add 'multiple' parameter to FileInput
paramenter filename can be a string or a list
parameter mime_type can be a string or a list
_process_property_change accounts for either a string or a list as input for 'msg'