Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline resources when saving #1956

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Fix inline resources when saving #1956

merged 2 commits into from
Feb 3, 2021

Conversation

philippjfr
Copy link
Member

Fixes #1949

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1956 (ebbf46a) into master (75edca1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
- Coverage   84.92%   84.90%   -0.03%     
==========================================
  Files         154      154              
  Lines       19003    19010       +7     
==========================================
+ Hits        16139    16140       +1     
- Misses       2864     2870       +6     
Impacted Files Coverage Δ
panel/io/resources.py 71.62% <100.00%> (+1.10%) ⬆️
panel/template/vanilla/__init__.py 88.23% <0.00%> (-0.66%) ⬇️
panel/compiler.py 10.00% <0.00%> (-0.45%) ⬇️
panel/template/base.py 75.64% <0.00%> (-0.27%) ⬇️
panel/template/bootstrap/__init__.py 100.00% <0.00%> (ø)
panel/template/theme.py
panel/template/theme/__init__.py 95.45% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75edca1...ebbf46a. Read the comment docs.

@philippjfr philippjfr merged commit 48da910 into master Feb 3, 2021
@philippjfr philippjfr deleted the fix_inline_on_save branch February 3, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saved HTML files do not get CSS resources inlined
1 participant