Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReactiveHTML JS model inherit from HTMLBox #2098

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Make ReactiveHTML JS model inherit from HTMLBox #2098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions panel/models/reactive_html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {html} from 'htm/preact';
import {build_views} from "@bokehjs/core/build_views"
import {isArray} from "@bokehjs/core/util/types"
import * as p from "@bokehjs/core/properties"
import {Markup} from "@bokehjs/models/widgets/markup"
import {HTMLBox} from "@bokehjs/models/layouts/html_box"
import {LayoutDOM} from "@bokehjs/models/layouts/layout_dom"
import {empty, classes} from "@bokehjs/core/dom"
import {color2css} from "@bokehjs/core/util/color"
Expand Down Expand Up @@ -375,7 +375,7 @@ export class ReactiveHTMLView extends PanelHTMLBoxView {
export namespace ReactiveHTML {
export type Attrs = p.AttrsOf<Props>

export type Props = Markup.Props & {
export type Props = HTMLBox.Props & {
attrs: p.Property<any>
callbacks: p.Property<any>
children: p.Property<any>
Expand All @@ -389,7 +389,7 @@ export namespace ReactiveHTML {

export interface ReactiveHTML extends ReactiveHTML.Attrs {}

export class ReactiveHTML extends Markup {
export class ReactiveHTML extends HTMLBox {
properties: ReactiveHTML.Props

constructor(attrs?: Partial<ReactiveHTML.Attrs>) {
Expand Down