Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Perspective drag errors #2300

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix Perspective drag errors #2300

merged 1 commit into from
May 10, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fix #2299

Added tests and a fix.

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #2300 (df0e078) into master (078c8b2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
+ Coverage   83.68%   83.69%   +0.01%     
==========================================
  Files         183      183              
  Lines       22018    22034      +16     
==========================================
+ Hits        18425    18442      +17     
+ Misses       3593     3592       -1     
Impacted Files Coverage Δ
panel/pane/perspective.py 54.14% <100.00%> (+0.43%) ⬆️
panel/tests/pane/test_perspective.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078c8b2...df0e078. Read the comment docs.

@philippjfr philippjfr merged commit ffa98c1 into master May 10, 2021
@philippjfr philippjfr deleted the fix-perspective branch May 10, 2021 08:56
@philippjfr philippjfr modified the milestones: v0.11.4, v0.12.0 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perspective raises error when trying to filter: ValueError: too many values to unpack (expected 3)
2 participants