Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Plotly pane resize when window resizes #2704

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fixes #1514

I've implemented the fix and tested that it works

plotly_resizing.mp4

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #2704 (f324c29) into master (42e1470) will decrease coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2704      +/-   ##
==========================================
- Coverage   83.06%   81.81%   -1.25%     
==========================================
  Files         184      187       +3     
  Lines       23319    23905     +586     
==========================================
+ Hits        19369    19558     +189     
- Misses       3950     4347     +397     
Impacted Files Coverage Δ
panel/io/server.py 58.07% <0.00%> (-3.26%) ⬇️
panel/tests/pane/test_base.py 84.00% <0.00%> (-3.24%) ⬇️
panel/io/callbacks.py 67.70% <0.00%> (-2.75%) ⬇️
panel/io/reload.py 66.66% <0.00%> (-1.88%) ⬇️
panel/io/__init__.py 91.66% <0.00%> (-1.67%) ⬇️
panel/widgets/indicators.py 91.97% <0.00%> (-0.63%) ⬇️
panel/pane/plot.py 58.58% <0.00%> (-0.60%) ⬇️
panel/tests/test_server.py 99.41% <0.00%> (-0.59%) ⬇️
panel/tests/test_reactive.py 98.68% <0.00%> (-0.38%) ⬇️
panel/viewable.py 67.91% <0.00%> (-0.38%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e1470...f324c29. Read the comment docs.

@philippjfr
Copy link
Member

Great!

@philippjfr philippjfr merged commit 1fab9bb into master Sep 2, 2021
@philippjfr philippjfr deleted the make-plotly-resize branch September 2, 2021 09:55
philippjfr pushed a commit that referenced this pull request Sep 16, 2021
Co-authored-by: Marc Skov Madsen <masma@orsted.dk>
maximlt added a commit that referenced this pull request Sep 16, 2021
* Fix #2631 - handle RuntimeError: dictionary changed size during iteration (#2632)

* Fix #2631 - handle RuntimeError: dictionary changed size during iteration

* Update panel/reactive.py

Co-authored-by: Marc Skov Madsen <masma@orsted.dk>
Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>

* Ensure tests pass in packaged version (#2636)

* Ensure tests pass in packaged version

* Update plotly test

* Add option to hide constant parameters (#2637)

* Add option to hide constant parameters

* Add test

* Add support for bokeh 2.4 (#2644)

* Ensure sessions get distinct files in config (#2646)

* Fix bug when updating Trend data (#2647)

* Enhance templates docs (#2658)

* clarifiy a sentence in the intro

* add a short definition for modal

* update the number of areas

* add links to template reference

* add an image of the 4 template areas

* add a modal section

* add link to the Golden framework

* clarify theming

* Added on_session_destroyed callback (#2659)

* Cleanup

* Ensure sorters are applied correctly after updating Tabulator value (#2639)

* Ensure sorters are applied correctly after updating Tabulator value

* Fix indents

* Add Folium reference notebook (#2672)

* add Folium reference

* clean up notebook

* Fix typo

* clear notebook

* Fix compatibility with bokeh 2.4 DocumentCallbackManager (#2687)

* Fix compatibility with bokeh 2.4 DocumentCallbackManager

* Fix flake

* correctly accessing the filtered dataframe for selection of tabulator… (#2676)

* correctly accessing the filtered dataframe for selection of tabulator #2642

* removing unused fixture

* Ensure threaded servers are killed after test failures (#2688)

* Unpin xarray

* Unescape child literal HTML in ReactiveHTML (#2690)

* Stricter validation for linking syntax in ReactiveHTML._template (#2689)

* Stricter validation for linking syntax in ReactiveHTML._template

* Add tests

* Update docs

* Clarify child templates

* fix-reloading (#2692)

Co-authored-by: Marc Skov Madsen <masma@orsted.dk>

* Ensure Trend indicator can be rendered in layout (#2694)

* Resolve remaining compatibility issues with bokeh 2.4 (#2696)

* resize plot when window resizes (#2704)

Co-authored-by: Marc Skov Madsen <masma@orsted.dk>

* Editable sliders' `name` can be changed (#2678)

* add tests for editable int and float sliders

* add failing tests when updating their name

* prevent the composite layout from using name

The Column/Row wrapping the composite widget inherited the name param
and watched it. This is no longer true, which allows the title of some
composite widgets to be updated.

* Switch binder links to latest version (#2705)

* fix-plotly-mapbox-relayout (#2717)

Co-authored-by: Marc Skov Madsen <masma@orsted.dk>

* Add the version number in the binder badge (#2711)

* Add the version number in the binder badge

Which should help us remember that the link has to be updated after a new release.

* Support assignment operators in ReactiveHTML scripts (#2718)

* Support assignment operators in ReactiveHTML scripts

* Add test

* Fix support for async functions on pn.state.add_periodic_callback (#2737)

* Upgrade to bokeh 2.4 and drop compatibility for older versions (#2739)

* Update changelog

* Fix rebase error

* Fix flake

* Bump panel.js version

* Fix rc version

* Update bokeh versions

Co-authored-by: Marc Skov Madsen <marc.skov.madsen@gmail.com>
Co-authored-by: Marc Skov Madsen <masma@orsted.dk>
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
Co-authored-by: Nestor Ghenzi <46707985+nghenzi@users.noreply.github.com>
Co-authored-by: Simon <simonparlow@gmx.net>
Co-authored-by: maximlt <mliquet@anaconda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive mode for Plotly plots not working in practice
2 participants