Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subclassed Tabs model that respects sizing_mode #3301

Merged
merged 4 commits into from
Apr 2, 2022
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 1, 2022

The Bokeh Tabs model does not use the sizing_mode/width|height_policy to determine the width/height of the tab headers which means that dynamic tabs sometimes collapse their tabs headers when dynamic tabs are enabled because the content of the tabs is not sufficiently wide.

Fixes #1231
Fixes #3041
Fixes #3064

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #3301 (db6facf) into master (d7a6b66) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3301      +/-   ##
==========================================
- Coverage   83.44%   83.35%   -0.10%     
==========================================
  Files         195      196       +1     
  Lines       26451    26485      +34     
==========================================
+ Hits        22072    22076       +4     
- Misses       4379     4409      +30     
Impacted Files Coverage Δ
panel/layout/tabs.py 88.28% <100.00%> (+0.10%) ⬆️
panel/models/__init__.py 100.00% <100.00%> (ø)
panel/models/tabs.py 100.00% <100.00%> (ø)
panel/widgets/input.py 94.18% <0.00%> (-2.16%) ⬇️
panel/pane/ipywidget.py 50.00% <0.00%> (-1.36%) ⬇️
panel/pane/plot.py 58.37% <0.00%> (-1.21%) ⬇️
panel/io/ipywidget.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a6b66...db6facf. Read the comment docs.

@philippjfr philippjfr merged commit 914ca6e into master Apr 2, 2022
@philippjfr philippjfr deleted the tabs_subclass branch April 2, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant