Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore scrollbar position when patching #3327

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Restore scrollbar position when patching #3327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions panel/models/tabulator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,9 @@ export class DataTabulatorView extends PanelHTMLBoxView {
_updating_page: boolean = true
_updating_sort: boolean = false
_relayouting: boolean = false
_selection_updating: boolean =false
_selection_updating: boolean = false
_initializing: boolean
_lastVerticalScrollbarTopPosition: number = 0;

connect_signals(): void {
super.connect_signals()
Expand Down Expand Up @@ -272,13 +273,8 @@ export class DataTabulatorView extends PanelHTMLBoxView {
this.connect(this.model.source.streaming, () => this.addData())
this.connect(this.model.source.patching, () => {
const inds = this.model.source.selected.indices
const visible = this.tabulator.rowManager.getVisibleRows(this.tabulator.rowManager.element)
this.updateOrAddData()
if (visible.length) {
const index = ((visible[0]?.data._index) || 0)
const row = this.tabulator.rowManager.findRow(index)
this.tabulator.rowManager.scrollToRow(row, 'end', false)
}
this.updateOrAddData();
this.tabulator.rowManager.element.scrollTop = this._lastVerticalScrollbarTopPosition;
// Restore indices since updating data may have reset checkbox column
this.model.source.selected.indices = inds;
})
Expand Down Expand Up @@ -449,10 +445,10 @@ export class DataTabulatorView extends PanelHTMLBoxView {
this.invalidate_layout()
const parent = (this as any).root._parent
if (parent != null && parent.relayout != null)
parent.relayout()
parent.relayout()
} else if ((this as any)._parent != null) { // HACK: Support ReactiveHTML
if ((this as any)._parent.relayout != null)
(this as any)._parent.relayout()
(this as any)._parent.relayout()
else
(this as any)._parent.invalidate_layout()
}
Expand Down Expand Up @@ -536,6 +532,7 @@ export class DataTabulatorView extends PanelHTMLBoxView {
return cell.getColumn().getField() + ": " + cell.getValue();
},
scrollVertical: debounce(() => {
this._lastVerticalScrollbarTopPosition = this.tabulator.rowManager.element.scrollTop;
this.setStyles()
}, 50, false),
rowFormatter: (row: any) => this._render_row(row),
Expand Down