Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tabulator UI tests #3633

Merged
merged 30 commits into from
Jul 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a5bef20
only install chromium and run the ui tests on chromium
maximlt Jun 17, 2022
3a37124
add first batch of tests
maximlt Jun 17, 2022
90c43bc
control modifier on windows
maximlt Jun 18, 2022
b13053e
guard playwright import
maximlt Jun 18, 2022
834d3a9
add coverage to the UI tests
maximlt Jun 22, 2022
a629b4d
add formatters ui tests
maximlt Jun 22, 2022
40b2a0c
add more tests, including xfail ones
maximlt Jun 26, 2022
8d61f5e
fix f-string
maximlt Jun 28, 2022
a86c62e
add codecov step in the ui job
maximlt Jun 28, 2022
7cb7e6e
reduce the default timeout
maximlt Jun 28, 2022
d2d4bf2
add tests
maximlt Jun 28, 2022
b670fe7
increase default timeout
maximlt Jun 29, 2022
06dc61d
make the tests more robust
maximlt Jun 29, 2022
f00719c
rewrite wait_until and add more tests
maximlt Jun 30, 2022
974c080
try with the codecov action
maximlt Jul 4, 2022
cf9dc0e
error on xpass
maximlt Jul 4, 2022
a850fca
add more tests
maximlt Jul 4, 2022
737dd78
increase timeout
maximlt Jul 5, 2022
cfdeb9d
generate xml coverage report
maximlt Jul 5, 2022
0faac50
increase timeouts
maximlt Jul 5, 2022
88b1721
more tests and attempt to stabilize some
maximlt Jul 6, 2022
02efa5d
increase timeouts
maximlt Jul 8, 2022
b6e0043
rename codecov flag
maximlt Jul 8, 2022
6aae871
set coverage concurrency lib for ui tests
maximlt Jul 9, 2022
2704220
move utils to the util test module
maximlt Jul 10, 2022
c795fb4
increase default playwright timeout
maximlt Jul 10, 2022
2aca2bc
more tests
maximlt Jul 11, 2022
44f736c
codecov cleanup
maximlt Jul 11, 2022
391c491
add comment about greenlet/coverage
maximlt Jul 11, 2022
a97913f
Merge branch 'master' into add_tabulator_ui_tests
maximlt Jul 14, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,12 @@ jobs:
eval "$(conda shell.bash hook)"
conda activate test-environment
doit test_examples
- name: codecov
run: |
eval "$(conda shell.bash hook)"
conda activate test-environment
codecov
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
files: ./coverage.xml
flags: unitexamples-tests
fail_ci_if_error: false # optional (default = false)
ui_test_suite:
name: UI tests on ${{ matrix.os }} with Python 3.9
needs: [pre_commit]
Expand Down Expand Up @@ -173,9 +174,15 @@ jobs:
run: |
eval "$(conda shell.bash hook)"
conda activate test-environment
playwright install
playwright install chromium
- name: doit test_ui
run: |
eval "$(conda shell.bash hook)"
conda activate test-environment
doit test_ui
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
with:
files: ./coverage.xml
flags: ui-tests
fail_ci_if_error: false # optional (default = false)
2 changes: 2 additions & 0 deletions .uicoveragerc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[run]
concurrency = greenlet
6 changes: 6 additions & 0 deletions panel/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ def pytest_configure(config):
else:
setattr(config.option, 'markexpr', 'not ui')

@pytest.fixture
def context(context):
# Set the default timeout to 20 secs
context.set_default_timeout(20_000)
yield context

PORT = [6000]

@pytest.fixture
Expand Down
Loading