Try to restore tabulator's scrollbar position on every renderComplete not only on the initial one

[Kadek]

No description provided.

[codecov]

Codecov Report

Merging #3645 (aa1a6ce) into master (ff39f02) will decrease coverage by 5.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3645      +/-   ##
==========================================
- Coverage   83.55%   78.19%   -5.36%     
==========================================
  Files         207      207              
  Lines       29654    29654              
==========================================
- Hits        24778    23189    -1589     
- Misses       4876     6465    +1589     

Flag	Coverage Δ
ui-tests	?
unitexamples-tests	78.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
panel/tests/ui/widgets/test_tabulator.py	10.10% <0.00%> (-87.98%)	⬇️
panel/tests/ui/widgets/test_card.py	16.15% <0.00%> (-83.85%)	⬇️
panel/tests/ui/test_reactive.py	26.53% <0.00%> (-73.47%)	⬇️
panel/tests/ui/pane/test_markup.py	30.43% <0.00%> (-69.57%)	⬇️
panel/tests/ui/template/test_fastlisttemplate.py	33.33% <0.00%> (-66.67%)	⬇️
panel/tests/ui/widgets/test_button.py	35.29% <0.00%> (-58.83%)	⬇️
panel/io/loading.py	61.90% <0.00%> (-38.10%)	⬇️
panel/tests/ui/io/test_state.py	38.88% <0.00%> (-33.34%)	⬇️
panel/tests/util.py	61.45% <0.00%> (-23.96%)	⬇️
panel/io/callbacks.py	74.61% <0.00%> (-3.85%)	⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

[maximlt]

Continuing the discussion that was going on in the issue #3249 here. Thanks for rebasing, that's helpful. Indeed the failing tests seem unrelated, they'll have to be fixed separately.

I recently added a UI Tabulator test that was marked as xfail, i.e. that is expected to fail, thinking that it would cover the issue your opened:

panel/panel/tests/ui/widgets/test_tabulator.py

Lines 1072 to 1073 in ff39f02

	@pytest.mark.xfail(reason='See https://github.com/holoviz/panel/issues/3249')
	def test_tabulator_patch_no_vertical_rescroll(page, port):

Fixing your issue in this PR should have made the test pass, and as it's marked as xfail it should actually show up as failed this time. It's not the case so something went wrong. It might be that the test I wrote is still failing for another reason, or that it was not covering the issue you reported but another one. I think it's the latter. I'll investigate and write a new test if need be.

[philippjfr]

Thanks @Kadek and sorry this has sat here for so long. Things have changed quite a bit so I'll likely have to find a new solution.