Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add Card UI tests #3654

Merged
merged 9 commits into from
Jul 9, 2022
Merged

Conversation

thuydotm
Copy link
Collaborator

@thuydotm thuydotm commented Jun 27, 2022

Addresses #3653 following the procedure in #3633. The newly added tests verify if Card components match the parameter setting values at initialization.

@philippjfr
Copy link
Member

Thanks @thuydotm! Could you install pre-commit and then run pre-commit install? That way it will automatically apply our code style and linters. I'd also run pre-commit run -a the first time to fix up this PR.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #3654 (fa00f99) into master (f4cf0ff) will decrease coverage by 0.41%.
The diff coverage is 16.15%.

@@            Coverage Diff             @@
##           master    #3654      +/-   ##
==========================================
- Coverage   82.32%   81.90%   -0.42%     
==========================================
  Files         205      206       +1     
  Lines       27893    28064     +171     
==========================================
+ Hits        22963    22987      +24     
- Misses       4930     5077     +147     
Impacted Files Coverage Δ
panel/tests/ui/widgets/test_card.py 16.15% <16.15%> (ø)
panel/io/callbacks.py 74.61% <0.00%> (-3.08%) ⬇️
panel/auth.py 39.34% <0.00%> (-2.11%) ⬇️
panel/util.py 85.60% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4cf0ff...fa00f99. Read the comment docs.

@philippjfr
Copy link
Member

Looks great, thank you!

@philippjfr philippjfr merged commit 9ca3a47 into holoviz:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants