-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Pixi for development / CI and hatchling for build system #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed duplicated from features
- Also marking a scipy dependent test as skipif
Also adding pyecharts to pixi.toml Adding packaging as required dependency in pyproject.toml
hoxbro
changed the title
[WIP] Switch to Pixi for development / CI and hatchling for build system
Switch to Pixi for development / CI and hatchling for build system
May 7, 2024
philippjfr
reviewed
May 8, 2024
philippjfr
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three items I'd like to see before merge:
- Merge dev doc notebook with md file
- Move build hooks to root
- Triple check contents of package matches older builds
Comparison between build artifacts for run 649 (main) and 652 (this PR) Wheel
Sdist*
Conda
NPM
*) For the existing sdist implementation, the doc folder has been removed. |
philippjfr
approved these changes
May 14, 2024
Thank you so much for all your work here! Let's find out how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More information can be found here: holoviz/holoviews#6182
TODO:
Decide what should be in optional dependenciesPostponed to the the futureAdd a Jupyterlite Pixi feature/environment? Thinking about having lite-build and lite-server as tasks.Postponed to the the future