Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sync StaticText.value with the frontend #7038

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jul 29, 2024

Fixes #2669
Fixes #7014

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.50%. Comparing base (a6f1503) to head (74525b5).

❗ There is a different number of reports uploaded between BASE (a6f1503) and HEAD (74525b5). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (a6f1503) HEAD (74525b5)
9 4
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7038      +/-   ##
==========================================
- Coverage   82.22%   72.50%   -9.73%     
==========================================
  Files         326      325       -1     
  Lines       48287    48306      +19     
==========================================
- Hits        39705    35024    -4681     
- Misses       8582    13282    +4700     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 310309e into main Jul 29, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the static_text_no_sync branch July 29, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant