Add pytypes property to parameters to return Python type declaration #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philippjfr do you need this in 2.0? |
|
I'll be glad to have this mapping between Parameter types and py3 types, but I can't comment on whether this is the best way to achieve that. Up to @philippjfr . |
|
I don't think it's ready, I want to revisit this as part of a more general plan for composite types as well as dataclass and pydantic integrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to split out the less experimental part of #636. This PR adds a
pytypesproperty to all Parameters that returns a Python type declaration for a specific parameter. This can be used in a number of ways, e.g. for documentation but also eventually for a tool that can automatically generate types for Parameterized classes (which I had prototyped in #636).