Warn instead or raise an error when doing an action before Parameterized initialization #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#834 added a few checks for preventing users from calling unsafe methods before a Parameterized instance has fully been initialized. This broke the hvPlot Explorer and is likely to break quite a lot of code, in particular for users who aren't so aware of the importance and meaning of calling
super().__init__(). I propose with this PR to downgrade these errors to warnings, to FutureWarnings in particular that will always be surfaced to users, as they're likely to be shooting themselves in the foot and we want to let them know about it.