Fix regression in ListSelector with check_on_set=False
#874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #872
I also found a pretty bad bug in
_instantiate_param_obj
where we were looping only through the__slots__
defined on the Parameter class, ignoring the ones it inherits. Easy mistake,kls.__slots__
should really return all the slots! This bug ledListSelector._objects
being shared between a Parameterized class and instance, since the_objects
slot is declared in a parent class.I also made sure that setting
None
withcheck_on_set=False
andallow_None=True
doesn't addNone
to the objects.