Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_fillna_frame and test_fillna_series extension array tests #100

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Skip test_fillna_frame and test_fillna_series extension array tests #100

merged 1 commit into from
Nov 22, 2022

Conversation

ianthomas23
Copy link
Member

Current failures in CI:

FAILED spatialpandas/tests/test_fixedextensionarray.py::TestGeometryMissing::test_fillna_series
FAILED spatialpandas/tests/test_fixedextensionarray.py::TestGeometryMissing::test_fillna_frame
FAILED spatialpandas/tests/test_listextensionarray.py::TestGeometryMissing::test_fillna_series
FAILED spatialpandas/tests/test_listextensionarray.py::TestGeometryMissing::test_fillna_frame

The original errors are:

NotImplementedError: <class 'spatialpandas.geometry.line.LineArray'> does not implement __setitem__.

So, as usual with new pandas ExtensionArray tests we skip them as we do not support this specific functionality.

@ianthomas23 ianthomas23 merged commit 26cfd93 into holoviz:master Nov 22, 2022
@ianthomas23 ianthomas23 deleted the skip_extension_array_tests branch November 22, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ianthomas23