Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use dtype=object when converting arrays to pass to shapely 2 #103

Merged
merged 4 commits into from
Dec 15, 2022
Merged

Don't use dtype=object when converting arrays to pass to shapely 2 #103

merged 4 commits into from
Dec 15, 2022

Conversation

ianthomas23
Copy link
Member

Potential fix for #102. The code change is to avoid using numpy arrays with dtype=object as shapely 2.0 quite rightly is not expecting this.

@ianthomas23 ianthomas23 added the bug Something isn't working label Dec 14, 2022
@ianthomas23
Copy link
Member Author

Forcing shapely >= 2.0 in CI works for Python 3.8+ on all 3 platforms. It fails for Python 3.7 as there are no conda-forge packages for shapely 2.0 for Python 3.7.

Reverting the shapely pin so that this is ready for merging.

@ianthomas23 ianthomas23 merged commit b3d7ba1 into holoviz:master Dec 15, 2022
@ianthomas23 ianthomas23 deleted the 102_TypeError_shapely_2 branch December 15, 2022 17:33
@ianthomas23 ianthomas23 mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ianthomas23