Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer contentType from playQueue items #457

Merged
merged 1 commit into from
Jan 30, 2021
Merged

Infer contentType from playQueue items #457

merged 1 commit into from
Jan 30, 2021

Conversation

maykar
Copy link
Contributor

@maykar maykar commented Jan 29, 2021

PlexAPI now has a getPlayQueue method that grabs the playQueue from server. This is now used in a new service to play a playQueue on plex capable media_players in HA 2021.2.0b1 (google cast devices, sonos, and plex clients). This fixes that service failing with:

AttributeError: 'PlayQueue' object has no attribute 'playQueueType'

playQueues from server have no playQueueType only PlexAPI playQueues have that attribute.

PlexAPI now has a getPlayQueue method that grabs the playQueue from server. HA plex capable media_players can now use this in a [new service to play a playQueue](home-assistant/core#45580). This fixes that service failing with `AttributeError: 'PlayQueue' object has no attribute 'playQueueType'`
Copy link

@jjlawren jjlawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it's handled in plexapi for native Plex clients. Looks good 👍

@balloob balloob merged commit 3e9899f into home-assistant-libs:master Jan 30, 2021
@maykar maykar deleted the patch-1 branch January 30, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants