Fix poll/select for Windows #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling in latest
Added in os detection so that select and poll are correctly utilized dependent on running OS.
Added a check to see if poll is part of avail methods on select object. Fixes the windows vs linux problem.
the hasattr check should take place only once as part of the class constructor, we simply check the object property on any subsequent call to run_once.
|
@emontnemery Can we get this merged / reviewed? I'm currently shipping my music player with 13.0.1 after realizing the 13.0.2 I shipped two days ago was buggy for my users. |
|
I'm thinking it may be prudent to just use your fork as the requirement as it incorporates 13.0.2..13.0.4? |
|
I dont see why you cant. The fix is pretty straight forward and works well. I have been using this fork for months on end without a single issue. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added OS detection in socket code. If os is not windows, the newer select poll code is used, otherwise the older working Windows code is utlized.