Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst to reflect refactoring of cast.device to cast.cast_info #751

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

davidjabon
Copy link
Contributor

Post version 10, "device" has been refactored to something similar "cast_info." Readme for current version should reflect this change, because the code will not run.

Post version 10, "device" has been replaced with "cast_info."  Readme for current version should reflect this.
Copy link
Collaborator

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davidjabon 👍

@elibroftw
Copy link

elibroftw commented Jan 21, 2024

Shouldn't this be a major change according to semver and not a minor? Just asking because I usually use ~=13.0 for pychromecast and the only reason I caught this is because I get all release notifications and saw this as a change.
EDIT: nvm, I was using cast_info the entire time???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants