Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change BBC Sounds app_id #753

Merged

Conversation

blawford
Copy link
Contributor

@blawford blawford commented Oct 12, 2023

BBC Sounds have changed their app_id.

@blawford
Copy link
Contributor Author

@emontnemery, could you approve this?

@orbsmiv
Copy link

orbsmiv commented Oct 17, 2023

Just bumping this PR as a bunch of my automations (that rely on playing BBC Radio!) are currently broken.

@jbeardon
Copy link

Another bump - workaround URLs being used as a temporary measure have now been removed by BBC 😒

@Jilas
Copy link

Jilas commented Oct 26, 2023

I'll add to this, spent the last hour wondering what I did to break the radio for my other half. Only to find the URLs when opened in a browser, just saying GONE.

Any log info etc you need, please ask, likewise happy to help test any solutions.

@blawford
Copy link
Contributor Author

@MartinHjelmare, can you merge this?

@MartinHjelmare
Copy link
Contributor

A codeowner should review.

@blawford
Copy link
Contributor Author

A codeowner should review.

Do you happen to know who that is? I thought I saw you approving dependency version increase PRs.

@MartinHjelmare
Copy link
Contributor

Dependency bumps normally don't require you to know the code of the library.

Erik is already tagged two weeks ago. No need to tag him again. When someone has time, they will get around to it.

@blawford
Copy link
Contributor Author

Dependency bumps normally don't require you to know the code of the library.

Erik is already tagged two weeks ago. No need to tag him again. When someone has time, they will get around to it.

In this case the only change is a change to an ID, so no code knowledge is really required.

Sorry, I don't mean to be a pain, I just wasn't sure whether Erik was a Home Assistant employee or whether he might not be active here anymore.

Copy link
Collaborator

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @blawford 👍

@emontnemery emontnemery merged commit 2aa4c7b into home-assistant-libs:master Nov 21, 2023
1 check passed
@orbsmiv
Copy link

orbsmiv commented Nov 22, 2023

This is live in the Home Assistant 2023.11.3 release and I can confirm that BBC Sounds casting is working for me.

@Jilas
Copy link

Jilas commented Nov 22, 2023

Strange not sure what I'm doing differently but just updated and still not playing any bbc channel apart from World Service. Trying to find some logs to see if I can work out why the update hasn't worked for me in the same way.

EDIT:

so manually steaming them to my Chromecast does work, but oddly trying to do this to the PC failed.

I'm also guessing the limited range is due to that's all we can get now with their restrictions (radio 2, 4, 5, 5ex, 6, some local channels). So no radio 1, 4ex, or most of the local stations.

Thanks for what we got. Let's hope a long term solution can be found, most like via an iPlayer style add-on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants