Make optional callback functions kwarg only #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
force-pushed
the
kwargs_only
branch
from
a550330 to
76fcdef
Compare
emontnemery
force-pushed
the
kwargs_only
branch
from
76fcdef to
d63713a
Compare
MartinHjelmare
approved these changes
Jan 15, 2024
Thanks Martin, the PR has been updated with this information |
|
I fixed a typo. |
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Most user facing functions accepting an optional callback function have been changed such that the optional arguments are now kwarg only
Change
Make optional callback functions kwarg only
Background
This is the first step in refactoring the callback functions to accept a bool status and an optional response.
Refactoring the callback handling is needed because callbacks are currently only called if the request suceeds; there's no call if the request fails. This means any user relying on callbacks will hang forever or until a timeout when the request fails.