Remove support for custom loop #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
approved these changes
Feb 13, 2024
vanadinit
added a commit
to vanadinit/terminalcast
that referenced
this pull request
May 10, 2024
I discovered, that the controls are no longer available with newer pychromecast version. This is possibly the case because of dropped support of custom loops: home-assistant-libs/pychromecast#837 I am going to investigate this further and how to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
It's no longer supported to use
pychromecastwith event custom loops.Change proposal and motivation
Remove support for custom loop. The code was not tested or maintained, and at conflict with the recently added error handling where commands wait for messages to be sent and a response to be received from the remote device.