Added brand icons for custom integration lucide-icons

[karlis-vagalis]

Proposed change

Type of change

• Add a new logo or icon for a new core integration
• Add a missing icon or logo for an existing core integration
• Add a new logo or icon for a custom integration (custom component)
  • I've opened up a PR for my custom integration on the Home Assistant
    Python wheels repository
• Replace an existing icon or logo with a higher quality version
• Removing an icon or logo

Additional information

• This PR fixes or closes issue: -
• Link to code base pull request: -
• Link to documentation pull request: -
• Link to integration documentation on our website: -

Checklist

• The added/replaced image(s) are PNG
• Icon image size is 256x256px (icon.png)
• hDPI icon image size is 512x512px for (icon@2x.png)
• Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
• hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

[frenck]

The domain name used for this integration isn't valid.

- are not allowed in integration domains, underscores (_) are allowed though.

../Frenck

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[karlis-vagalis]

Renamed to lucide_icons

[frenck]

The upstream integration doesn't match the latest changes:

This PR will have no effect. Please make sure it matches

../Frenck

[karlis-vagalis]

I am aware of this. This mismatch will be solved tomorrow. I would really appreciate if this PR would still be merged, to not delay this integration being published on HACS any longer.

[frenck]

Sorry, can't merge the PR if it ain't correct.

../Frenck

[karlis-vagalis]

What a joke. Here you go.

[frenck]

What a joke.

I'm sorry? I don't think that is called for or a needed comment/attitude to put out.

../Frenck

[karlis-vagalis]

I'm sorry? I don't think that is called for or a needed comment/attitude to put out.

Well, we disagree in that regard then 🤷🏻‍♂️

[frenck]

There is no good reason to mock a review with "What a joke".

There is a difference between not agreeing with the project's policies versus leaving a comment like that. It is just disrespectful.

I hope you understand I'm less motivated to complete this review. I'll leave it for someone else to pick up instead.

../Frenck

[karlis-vagalis]

There is no good reason to mock a review with "What a joke".

There is a difference between not agreeing with the project's policies versus leaving a comment like that. It is just disrespectful.

I hope you understand I'm less motivated to complete this review. I'll leave it for someone else to pick up instead.

Well, take all the time you need. Oh no, poor me, being held hostage.

Secondly, the requirements from HA Developer docs say, that the domain name can contain characters and underscores. It does not say only alphanumerical characters and underscores. In addition to the integration domain names in this repo: several with - in the custom_components folder. Just FYI

[frenck]

Well, take all the time you need. Oh no, poor me, being held hostage.

Alright, that does it.

Going to close this PR for the above behavior. Please consider this a warning for violating our Code of Conduct.

../Frenck

[karlis-vagalis]

Yes, just ignore the brought up arguments. You know what is especially funny? You just make the life harder for people who want more convenient way to install and update this integration. I don't need it: I wrote this integration, I know how to install it and always have the latest version anyways.