Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #101651

Merged
merged 20 commits into from
Oct 10, 2023
Merged

Add support for Python 3.12 #101651

merged 20 commits into from
Oct 10, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Oct 8, 2023

Breaking changes

The following integrations won't work with Python 3.12 and might be removed in the future.

The profiler.memory service is not available when using Python 3.12. It will return if and when guppy3 becomes Python 3.12 compatible.

Proposed change

--
Add initial support for Python 3.12.
The following integrations don't work yet.

Install / build error

Import error

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cdce8p cdce8p removed small-pr PRs with less than 30 lines. has-tests labels Oct 8, 2023
pyproject.toml Outdated Show resolved Hide resolved
@cdce8p cdce8p mentioned this pull request Oct 8, 2023
20 tasks
@cdce8p cdce8p force-pushed the add-python-312 branch 5 times, most recently from e5b46a0 to 1a5de8e Compare October 10, 2023 10:35
@cdce8p cdce8p added breaking-change noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) labels Oct 10, 2023
@cdce8p cdce8p marked this pull request as ready for review October 10, 2023 12:26
@cdce8p cdce8p requested review from bdraco, bieniu, bachya and a team as code owners October 10, 2023 12:26
@cdce8p cdce8p requested a review from frenck October 10, 2023 12:27
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Thanks, @cdce8p! Amazing job! 👍

../Frenck

@frenck frenck merged commit ba91aaa into dev Oct 10, 2023
50 of 54 checks passed
@frenck frenck deleted the add-python-312 branch October 10, 2023 19:34
@cdce8p cdce8p mentioned this pull request Oct 10, 2023
32 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed Hacktoberfest noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants