-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TURN_OFF/TURN_ON feature flags for fan #121447
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
d03937a
to
adc89df
Compare
Remaining test failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
776b695
to
4beb40c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
4beb40c
to
e89b657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gjohansson-ST 👍
../Frenck
Proposed change
Add feature flags
TURN_OFF
/TURN_ON
forFanEntity
.It's a "copy/paste" implementation similar to
ClimateEntity
Integations should set
_enable_turn_on_off_backwards_compatibility
toFalse
to identify as migrated.If integrations sets the new feature flags directly from start it will not log for above.
If integrations implements the
turn_on
/turn_off
methods but doesn't set the new feature flags or doesn't set_enable_turn_on_off_backwards_compatibility
toFalse
it will automatically add the new feature flags and log a warning.Todo
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: