Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TURN_OFF/TURN_ON feature flags for fan #121447

Merged
merged 9 commits into from
Jul 19, 2024
Merged

Conversation

gjohansson-ST
Copy link
Member

@gjohansson-ST gjohansson-ST commented Jul 7, 2024

Proposed change

Add feature flags TURN_OFF/TURN_ON for FanEntity.

It's a "copy/paste" implementation similar to ClimateEntity

Integations should set _enable_turn_on_off_backwards_compatibility to False to identify as migrated.
If integrations sets the new feature flags directly from start it will not log for above.

If integrations implements the turn_on/turn_off methods but doesn't set the new feature flags or doesn't set _enable_turn_on_off_backwards_compatibility to False it will automatically add the new feature flags and log a warning.

Todo

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jul 7, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (fan) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fan can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fan Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST
Copy link
Member Author

Remaining test failure conversation timeout is not related to this PR

Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hi there @gjohansson-ST 👋

A wild merge conflict showed up! Could you take a look?

../Frenck

@home-assistant home-assistant bot marked this pull request as draft July 10, 2024 22:45
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@gjohansson-ST gjohansson-ST marked this pull request as ready for review July 11, 2024 06:59
@home-assistant home-assistant bot requested a review from frenck July 11, 2024 06:59
@frenck frenck added this to the 2024.8.0b0 milestone Jul 16, 2024
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 19, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @gjohansson-ST 👍

../Frenck

@frenck frenck merged commit ca4c617 into dev Jul 19, 2024
40 checks passed
@frenck frenck deleted the fanentityfeature-turn_on_off branch July 19, 2024 09:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants